I think the problem is that you're trying to build the Tr all at once. Use the conditionals to determine your branching, and leave the stuff that's not conditional (e.g. $ref->{'loc'}) outside of the if blocks. Construct the Tr after you've figured out what it's made of.

The below code doesn't exactly reproduce the functionality of your code, but it's probably good enough (or can be adjusted). 

my @tds = ();
if ($ref->{'pic'}) {
    push @tds, $q->a({href=>"$ref->{'pic'}"},$ref->{'name'});
} else {
    push @tds, "<LI>".$ref->{'name'};
}

push @tds, $ref->{'phone'};

if ($type eq 'f' || $type eq 'c') {
    push @tds, $ref->{'fax'};
} else {
    push @tds, $ref->{'cell'};
}

push @tds, $ref->{'loc'};

if ($type eq 'c') {
    push @tds, $ref->{'con'};
} else {
    push @tds, $q->a({href=>"mailto:$ref->{'email'}"},$ref->{'email'})
+;
}

print $q->Tr([$q->td({-bgcolor=>$cellcolor},\@tds)]);

[download]

In reply to Re: Simplifying repetitive flow structures by eisenstein
in thread Simplifying repetitive flow structures by Dogma

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.