You do use flock, which is good, but if the file is opened while another instance is in the for()-loop, the counter will in effect only be increased once. To avoid this race condition, you have to write to the file without closeing it after reading. This can be done using a read+write mode. 

sub counter {
    my ($file) = @_;
    local *COUNTER;
    local $/ = undef;
    open           COUNTER, '+<', $file or
    open           COUNTER, '>',  $file or return undef;
    flock          COUNTER, 2;
    seek           COUNTER, 0, 0;
    my $counter = <COUNTER>;
    seek           COUNTER, 0, 0;
    truncate       COUNTER, 0;
    print          COUNTER ++$counter;
    close          COUNTER;
    return $counter;
}

[download]
There are also CPAN modules that do this, but I think modules are overkill for a ++. 

- Yes, I reinvent wheels.
- Spam: Visit eurotraQ.

In reply to Re: simple IP counter.. by Juerd
in thread simple IP counter.. by coldhawk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.