I think your script is great, so forgive me if this seems
a bit nit-picky :)
I think you could improve your script like so ...
change
my $sock;
my @openports = ();
my $i = -1;
print "Scanning $host for open ports.....\n\n";
foreach my $cport (@ports) {
$sock = IO::Socket::INET->new(PeerAddr => $host,
PeerPort => $cport,
Proto => $proto);
if($sock) {
$i++;
$openports[$i] = $cport;
}
}
... to ...
my $sock;
my @openports = ();
print "Scanning $host for open ports.....\n\n";
foreach my $cport (@ports) {
$sock = IO::Socket::INET->new(PeerAddr => $host,
PeerPort => $cport,
Proto => $proto);
if($sock) {
push ( @openports, $cport);
}
}
... that $i = -1 thing bugs me :/
But good example of a port scanner!
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.