And, of course, you could move the check on the @variables outside the processing loop. Then you'll get an error, and no output, rather than half the output and an error. Also, the filename really, really ought to be validated in someway, in case somebody submits (for example) "> /etc/passwd", which would promptly attempt to erase your password file (I'm only going to force the file to be opened for reading, which still isn't adequate, but it's an improvement).

foreach $variable (@variables) {
   die "Incomplete $variable\n"
     if $FORM{$variable} eq "";
}
open FILE, "< $FORM{'TextFile'}"
  or die "Cannot open TextFile $FORM{'TextFile'}";
foreach $line (<FILE>) {
  foreach $variable (@variables) {
    $line =~ s/<!--$variable-->/<STRONG>$FORM{$variable}<\/STRONG>/g;
  }
  $line =~ s/A\/an <STRONG>(a|e|i|o|u)/An <STRONG>$1/g;
  $line =~ s/a\/an <STRONG>(a|e|i|o|u)/an <STRONG>$1/g;
  $line =~ s/A\/an/A/g;
  $line =~ s/a\/an/a/g;
  print "$line\n";
}
close FILE;

[download]

--
Tommy
Too stupid to live.
Too stubborn to die.

In reply to Re: Re: Keep file formatted by tommyw
in thread Keep file formatted by wolverina

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.