I'd like to make a few suggestions for improving this useful module.

  1. You should use the second argument to bless in case someone wants to subclass this class.
  2. All of the attribute accessor functions are identical. Is there potential to make them all one function - or perhaps to do something clever in AUTOLOAD.
  3. The addCell function takes rather a lot of parameters. It might be easier to use if you used named parameters rather than positional ones.
  4. code like push(@font, " $opt$i=\"" . $self->{$opt$i} . "\"") might be easier to understand if it was written as push(@font, qq( $opt$i="$self->{$opt$i}")).
  5. Why not use the CGI.pm table creation functions to build your table elements?

Hope you find this helpful. Let me know if I can clarify anything.

--
<http://www.dave.org.uk>

European Perl Conference - Sept 22/24 2000, ICA, London
<http://www.yapc.org/Europe/>

In reply to RE: TableMaker by davorg
in thread TableMaker by Houblon

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.