Amongst other things, the following line is in error and will cause your script to fail:

    open(FILE, '>>fai.txt') ||  die $!;

[download]

The >> cause the file to be opened in "append" mode. You want "read" mode. You can do this to correct this:

    sub search {
        my ($file,$part_number,$revision) = @_;
        open FILE "< $file" or die "Cannot open ($file) for reading: $
+!";

        local $_;
        while (<FILE>) {
            # search line for $part_number

[download]

Note that I have have made some changes. First, I have explicitly passed the necessary arguments to the subroutine. This makes it easier to reuse or move to a library, if necessary. Further, I've localized $_. This restricts changes to $_ to the current scope, thus ensuring that if another part of your program uses $_, you won't accidentally have a strange value in there. See perldoc -f local for more information on this.

Cheers,
Ovid

New address of my CGI Course.
Silence is Evil (feel free to copy and distribute widely - note copyright text)

In reply to Re: pulling information from a delineated text file using a subroutine by Ovid
in thread pulling information from a delineated text file using a subroutine by Bismark

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.