# Output an image to the browser
sub show_img {
 my $img = shift;
 my ($mime) = $img =~ /\.(gif|jpe?g|png)$/;
 $mime = 'jpeg' if $mime eq 'jpg';
 open my $fh, '<', $img or die "Could not open $img for read: $!";
 binmode $fh;
 my $img_data = do { local $/; <$fh> };
 close $fh;
 print header('image/' . $mime), $img_data;
 exit;
}
[download]

Rather than pump the image yourself, I'd put the images somewhere in your www-server space (an unlinked unannounced directory), and then use an internal redirect:

print redirect("/some/webpath/to/selected/image.jpg");
[download]

The advantages are many:

• The server is better than you at pumping data.
• The values of last-modified and if-modified-since will be respected, allowing the server to avoid sending the data if the browser already has the image cached.
• You won't ever be able to accidentally access something outside the normal htdoc tree, even from bad programming or malicious hacking.
• Your CGI process goes away quicker.
• The code will be eight lines shorter. {grin}

-- Randal L. Schwartz, Perl hacker
Be sure to read my standard disclaimer if this is a reply.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.