I fully understand what you said, but I think your teammates’ thinking is also valid. If your old code still works, it still works, although it might have a “bad” style as you said. I would say, for any new development, you should go with the “good” style, there is no doubt about that.

But for existing code in your repository, you don’t just go back, and modify them because their style is “bad” (I rather say it is “old”, it might be “good” at the time it was developed.) To keep your system stable is also a “good” practice.

Any way, discuss with your teammates more, but don’t bluntly call their opinion as bad practice. Bad practice is a very serious accusation against programmers, and some people really care. The purpose of pushing your idea is to make others accept it, you have to do it skillfully, if you push too hard, chance is that you will achieve nothing but to hurt the synergy among teammates…

I know you can make it, good luck ;-)

In reply to Re: Bad Practice by pg
in thread Bad Practice by mkirank

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.