the call to system() looks fine. The first thing that pops into my mind is: are you running the script as root? if not, do you have it setuid root? /usr/sbin/useradd needs write access to /etc/passwd, and this means root privileges in unix. You want to check the return value of system().
Since this code needs root privileges, you have to make sure your code is safe. You will want to run this under taint mode. (check perlsec for info, taint mode will be turned on for setuid or setgid scripts.) You want to make sure that any user input is safe to pass on to system().
debian's adduser program is written in perl, maybe you could check it for some ideas.

One last thing: are you aware that exec never returns? You probably want a call to system (since it does a fork and waits for the external command to finish) when working with /usr/bin/passwd.

just my 2 cents,

In reply to Re: Public Access Linux Box by CukiMnstr
in thread Public Access Linux Box by lacertus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.