First, I would recommend using some sort of templating system, such as HTML::Template. HTML mixed in with your code is generally frowned upon. Once you've removed the HTML from your code you'll find that it's much easier to read and make improvements to.

In the area of code improvement, I would recommend seperating your code into functions or even to go as far as to split it up into modules if you feel that it's warranted. How far you want to go is up to you, everyone has there own opinion and style.

Lastly, I would recommed that you read the Program Repair Shop and Red Flags series of articles by Mark-Jason Dominus. They'll give great ideas as to how you can improve your code and what to look for that can use improvement.



In reply to Re: creating report tables by Abstraction
in thread creating report tables by semio

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.