I'm using a regex to check for illegal input in a CGI script. since there are rather a lot of variables I thought I'd write a subroutine to help me out. This is what I have written:
#!/usr/bin/perl -w
#use strict;
use CGI::Carp qw(fatalsToBrowser warningsToBrowser);
use CGI ':standard';
my $one = "apple";
my $two = "pear";
my $three = "ba\$\£na\¨na";
my @vars;
my $ILLEGAL_CHARS = qr/[^\w\.-\s\@\(\)\Ó,]/;
@vars = ($one,$two,$three);
($one,$two,$three) = legal(@vars);
print header(), start_html(-title => "fruits");
print "$one,$two,$three";
print end_html();
sub legal {
foreach $item (@vars) {
$item =~ s/$ILLEGAL_CHARS/_/g;
}
return @vars;
}
My questions are:
When I use strict I get syntax errors for every single part of the regex - how can I use strict?
I have included as allowed things like ',' and '( )' to make life more agreeable for the user. Is there still enough there to prevent tampering? Can I improve the regex?
Is the subroutine set okay or can I improve on that. General comments welcome.
With thanks.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.