It probably doesn't work right because you're using the numeric comparison operator (==) on data that is probably strings. You should have used eq instead. But that's not all that you need to fix.

The first thing that comes to mind when I look at your code is that you're not really taking advantage of true power of hashes. Instead of walking through the hash and comparing $thing to $key, you want to use $thing as the key, like this:

foreach my $thing (@array) {
    if(exists $hash{$thing}) {
       push @new_array, $hash{$thing};
    }
}

[download]

If you're not afraid of grep, try this:

my @new_array = grep { exists $hash{$_} ? $hash{$_} : 0 } @array;

[download]

But that will fail if %hash contains false values.

Update: Was using $thing in the grep when I should have used $_. Thanks to davorg.

----
I wanted to explore how Perl's closures can be manipulated, and ended up creating an object system by accident.
-- Schemer

Note: All code is untested, unless otherwise stated

In reply to Re: comparing array elements to hash keys by hardburn
in thread comparing array elements to hash keys by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.