First - use strict; - you will have a million issues if you don't. Secondly, PASS THINGS IN! You're using global variables. This is highly unmaintainable code.

If I understand your question right, you might be passing @fields in to Write_leads(). Ok ... that's not a problem. 

sub Write_leads
{
    my ($fields, $table, $list) = @_;

    my $parms = join (',', ('?') x @$fields);
    my $sth = $dbh->prepare_cached("INSERT INTO $table VALUES ($parms)
+") || die $dbh->Errstr;
    foreach my $href (@$list)
    {
        $sth->execute(@{$href}{@$fields}) || die $dbh->Errstr;
    }
    $sth->finish;
}

[download]
That not only will run under strict, but will catch DB errors you might have (for example, your tablename which is a variable might be wrong ...)

------
We are the carpenters and bricklayers of the Information Age.

Don't go borrowing trouble. For programmers, this means Worry only about what you need to implement.

Please remember that I'm crufty and crochety. All opinions are purely mine and all code is untested, unless otherwise specified.

In reply to Re: DBI and two arrays question! by dragonchild
in thread DBI and two arrays question! by jdtoronto

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.