I wrote a script that checks fields (delimiter is a pipe) where if the last entry has the same last four field entries it will eliminate that last line with the duplicates. The script works but as usual I like to get it to look better and this site always provides a great way to critique and help me write a more efficient script. Please look at the script and advise how I can make it better.
Thanks!
Script:
use strict;
my $db = 'C:\Inetpub\wwwroot\cgi-bin\test4.txt';
open(DATA, "$db") || die "Can not open: $!\n";
my @dat = (<DATA>);
close(DATA);
open(DATA, "$db") || die "NO GO: $!\n";
my @files;
foreach (@dat)
{
my $key = join(" ", (split /\|/, $_)[1,2,3,4]);
#print "$key\n";
push(@files,$key);
}
#print "@files\n";
foreach (@files)
{
chomp;
$key{$_}++;
}
foreach (keys %key)
{
if($key{$_} > 1)
{
#print "$_ \n";
my $db = 'test4.txt';
open(DATA, "$db") || die "Can not open: $!\n";
my @lines = (<DATA>);
pop @lines;
open(FOUT,"> test4.txt") or die $!;
print FOUT @lines;
close FOUT;
}
}
close(DATA);
data in test4.txt:
34|4|45|56|45
45|34|45|00|23
45|34|45|00|27
34|4|456|56|03
36|4|456|56|03 #This line will be eliminated after the script is run
+because last four fields are the same as the previous line.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.