You are passing the array to makeSQL as a ref here: 

my $sql = makeSql(\@xpid);

[download]
However here you make an error: 
sub makeSql {
  my @xpid = shift; # <----------- error
  my $return;       # try: my $xpid = shift
  my $i = 0;                  ^
  foreach my $item (@xpid) { # <-- error
    $return .= $xpid[$i];    # <-- error

# try: foreach my $item (@$xpid)
                         ^
# try: $return .= $$xpid[$i];
                  ^

[download]
The reference the is passed to the function should be stored in a scalar. When it then needs to be used as an array you dereference it with @$xpid and then again with $return .= $$xpid[$i];.

--tidiness is the memory loss of environmental mnemonics

In reply to Re: Help w passing array by ref by EvdB
in thread Help w passing array by ref by alienhuman

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.