Id just like to point out that this is some scary code. Duplication like you have in that first section just screams out "refactor me!" You should convert as much of that into a subroutine, and then call it twice with the appropriate values. A perfect example of why you should do this are the following two lines

$s_ftp->binary() or die $s_ftp->message; $d_ftp->binary() or die $s_ftp->message;

while you were cutting an pasting you forgot to change the second error condition from $s_ftp to $d_ftp. If I were writing it the code would probably look something like this:

use strict; use warnings; use Carp; sub die_msg { my $ftp=shift; Carp::confess join "",@_,":\n",$ftp->message; } sub do_connect { my ($user,$pass,$host,$dir)=@_; my $ftp=Net::FTP->new($host) or die "Failed to connect to host '$host':$@"; $ftp->login($user,$pass) or die_msg $ftp,"Failed login"; $ftp->binary() or die_msg $ftp,"Failed to switch to binary mode"; $ftp->cwd($dir) or die "Cant cwd '$dir'"; return $ftp; } my $source_ftp=do_connect('user1','mypassword','some-server.com','/hom +e/test/source'); my $dest_ftp =do_connect('user2','mypassword','some-server.com','/hom +e/test/dest'); my $source_file = "test.txt"; my $dest_file ||= $source_file; $source_ftp->pasv_xfer($source_file, $dest_ftp, $dest_file) or warn "Failed xfer:\n" . $source_ftp->ok ? $dest_ftp->message : $source_ftp->message;

(Yes I know this doesnt address your real question. But this is also good advice. :-)

---
demerphq

    First they ignore you, then they laugh at you, then they fight you, then you win.
    -- Gandhi



In reply to Re: comparing files after FTP by demerphq
in thread comparing files after FTP by nsyed

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.