First of all, the line:

my $line = $self->SUPER::getline() || return undef;
[download]

has a problem; what if $self->SUPER::getline() returns "0"? Or ""? (which may happen if you don't subclass from IO::Handle directly, or if you are working with IO layers).

As for what to return if the line is illformatted, you can do several things:

• Return 'undef' after setting $! or some other global variable, and leave it to the caller to inspect it.
• die with an appropriate message; it's up to the caller to use eval {} and catch an error.
• Return an overloaded object that is undefined in boolean context, but which can be inspected by the caller. You might return an overloaded object if your superclass returns undefined as well.
• Always return an object, whether on failure or success. It's up to the caller to inspect that object, and retrieve either the string, or the failure reason.

Anyway, you need to return something special, which you document well, and it's up the caller to inspect your return value and handle appropriately.

I probably would use the first suggestion.

Abigail

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.