Though I'm responding to Zaxo, my comment applies to most of the answers I see. With code doing a split, check that $pair[1] aka $ip is actually getting set to a defined value. Otherwise, your hash value may be undef on bad input but you won't get a warning about it until you actually try to use the hash value later on. Best to validate as you go: 
while (<$fh>) {
   chomp;
   my ($host, $ip) = split;
   warn("bad hosts line: $_"),next if !defined $ip;
   $hosts{$host} = $ip;
}

[download]
Note that if you check defined($ip) the chomp is necessary, since otherwise $ip set to the empty string (taken from the empty string following the newline character). If you use a regex to split up the line instead, make sure it actually requires both fields and check if the match succeeds (which gets a little funky if you are using map): 
%hosts = map {
   if (/^(\w+)\s(.+)/) {
      ($1 => $2)
   } else {
      (warn "bad hosts line: $_")[1..0];
   }
} <FILE>;

[download]

In reply to Re: Re: newbie hasher by ysth
in thread newbie hasher by prodevel

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.