Err -- whoa there. There are a few problems with this code. First off, let me clean it up a little (such as actually passing it an array with some elements in it) and feed it though with -w -Mstrict

my @array = (42,43,44,45); my $scalar1 = 1; my $scalar2 = 2; ($scalar1,$scalar2) = my_subroutine(@array,$scalar1, $scalar2); print "$scalar1 $scalar2\n"; sub my_subroutine() { my @a = @{shift()}; my $s1 = shift(); my $s2 = shift(); print "array: @a\ns1: $s1\ns2: $s2\n"; $s1 += 22; $s2 += 33; return ($s1, $s2); }

..to which perl says:

main::my_subroutine() called too early to check prototype at - line 5. Can't use string ("42") as an ARRAY ref while "strict refs" in use at +- line 9.

..which shows the two most glaring bugs in the code. First off, you've given your subroutine a prototype, which only works if your calls to the subroutine are after its declaration. If you move the subroutine to above the call, however, we discover that you're giving the wrong prototype, anyways! (Too many arguments for main::my_subroutine at - line 15, near "$scalar2)")

You're also passing in an array, and trying to treat it as an array reference in the code. That's what the second error message is telling you.

These are all vaguely fixable by changing your code to:

sub my_subroutine(\@$$) { my @a = @{shift()}; my $s1 = shift(); my $s2 = shift(); print "array: @a\ns1: $s1\ns2: $s2\n"; $s1 += 22; $s2 += 33; return ($s1, $s2); } my @array = (42,43,44,45); my $scalar1 = 1; my $scalar2 = 2; ($scalar1,$scalar2) = my_subroutine(@array,$scalar1, $scalar2); print "$scalar1 $scalar2\n";

..but don't do that, as prototypes are mostly broken and confusing. This public service announcement has been brought yo you by the letter P and the number 42.

Networking -- only one letter away from not working

In reply to Re: Re: Passing multiple data types to a subroutine by Chmrr
in thread Passing multiple data types to a subroutine by Hagbone

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.