1. There is nothing per se wrong with the kluge.
  2. You don't post your code which is broken (despite the SUGGESTION!)
  3. You are trying to parse totally invalid Javascript. Save it as test.html and click on the little yellow ! mark in the bottom left of your IE to read about the errors.
  4. I see no possible way you could get the output you describe from the input shown. There is no newline embedded between the mysite.com url and the //-->. If you posted the parsing code as asked then I would hazard the suggestion we might be able to suggest why/where/how it is broken so it could be fixed!

This will parse your totally invalid input for links (making the rash and UNSPECIFIED BY YOU assumption that that is the task). It definitely falls in the category of EXTREME KLUDGINESS. 

while(<DATA>) {
    m!(https?://[^"'>\s]+)! or next;
    $url = $1;
    $url =~ s/--$//;
    print "$url\n";
}

__DATA__
<html>
<head> 
<script language="JavaScript"> 
<!-- 
function load(){ 
document.write("<img src='photo.jpg' width='1' height='1'>"); 
window.location="http://mysite.com/stuff/file.htm";}//--> 
window.location="<!--http://www.login.com-->";}//--> 
</script>
</head> 

<body onload=load()> 
<img src="http://mysite.com//photo.jpg" width="1" height="1"><br> 
</BODY>
</HTML>

[download]

cheers

tachyon

In reply to Re: Re: Re: File glitch by tachyon
in thread File glitch by wolverina

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.