Might the file that is being uploaded by an image or an mp3 or some other binary file? If so your reading routing ought to look something more like this:
my $filehandle = $q->param('file');
my($buffer,$bytesread,$has_data);
if( $cfg{filetype} eq 'binary' ) {
open(OUTFILE,">$cfg{savename}")
or return("Couldn't open '$cfg{savename}' for writing: $!"
+);
binmode OUTFILE;
while ( $bytesread=read($original_name,$buffer,$cfg{max_bytes}
+)) {
print OUTFILE $buffer;
$has_data++;
}
close OUTFILE
or return("Couldn't close '$cfg{savename}': $!");
if(!defined $bytesread) { return("$!"); }
}
else {
open(OUTFILE,">$cfg{savename}")
or return("Couldn't open '$cfg{savename}' for writing: $!"
+);
while (<$original_name>) {
print OUTFILE;
$has_data++;
}
close OUTFILE
or return("Couldn't close '$cfg{savename}': $!");
}
if( !$has_data ) {
return(qq/
Nothing in '$original_name'.<br>
It either doesn't exist, or is empty.'
/);
}
return '';
You should also have something like this unless you like DOS attacks:
$CGI::POST_MAX = $cfg{max_bytes};
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.