After further consideration, if you're wanting to print up to 500 lines total for each unique IP#, you should try a hash instead of the array. Take a look at this: 

open (LOG, "$fw_logfile") or die and mail_error($!);
open (OUTFILE, "+>>$outfile") or die and mail_error($!);

my %newIPseen;

foreach my $i ( @newips ) {
    $newIPseen{$i} = 0;
}

while (<LOG>) {
    foreach $i ( keys( %newIPseen ) ){
        unless ( $newIPseen{$i} == 500 ) {
            print OUTFILE if (/\;drop;[^"]*$i/) && $newIPseen{$i}++;
        }
    }
}

[download]

Now, if you load the hash %newIPseen in the first place instead of the array @newips, you can get rid of the first foreach loop.

In reply to Re: Correct Loop Structure by arden
in thread Correct Loop Structure by Dru

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.