if ( $today > $start && $today < $stop ) {
  if ( $today!= $notthisday[0] ) {            
    if ( $today != $notthisday[1] ) {              
      if ( $today != $notthisday[2] ) {                
        if ( $day == $dayofmon[0] || $day == $dayofmon[1] ) { 
          print "$today is the day.";
        }
      }
    }
  }
}

[download]

I'd have to kill you if you implemented this in my code base :)

The and-composite is much better and will not draw criticism. By any chance could you put a negated grep in there for the notthisday part to make it a little more Perlish? Also, add some parens rather than relying on your knowledge of the operators as a cautionary technique.

Halley's quick fail routine is one I like a lot, but I think kesterkester's technique may be better for more complex tests, to a C programmer, that's just extra code to read through (IMHO) -- yet allows you to reuse things at the price of method call overhead. But hey, if you are reusing things, you are better off using a really cool well-tested Date module!.

In reply to Re: Nested testing of many conditions--a better way? by flyingmoose
in thread Nested testing of many conditions--a better way? by bradcathey

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.