I am writing a script to run a series of perl-scripts/system commands, but I want to make sure that if something goes wrong nothing else happens. Is die the best way of going about this, or do you think there should be some form of error handling instead?

chdir("$staging_directory") or die "Could not change directory to $staging_directory: $!\n"; system("svn", "update", "base") or die "Could not svn update base: $!\n"; system("svn", "update", "hostgroup") or die "Could not svn update hostgroup: $!\n"; system("svn", "update", "host") or die "Could not svn update host: $!\n"; system("$copier_program_location", "$staging_directory", "$pre_launch_ +directory", "$copier_conf_file") or die "Could not run copier $copier_program_location: $!\n"; system("$permissions_program_location", "-c", "$permissions_conf_file" +) or die "Could not run permissions program $permissions_program_loc +ation: $!\n"; system("rsync", "-avz", "--exclude=.svn", "--delete-after", "$pre_laun +ch_directory", "$live_directory") or die "Could not perform rsync from $pre_launch_directory to $liv +e_directory: $!\n";
On a side note, are system() calls the best way to call other perl scripts, or would some kind of use or sub better form? (The $blah_program_location above are perl scripts)

Thanks in advance.

-Shane


In reply to Is "die" the best way to be atomic? by BuddhaNature

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.