The problem is that all four buttons are inside the same loop iteration, so $_ is set to the same thing all four times you call it. What you want is something like this (untested): 
my @cols = ();
foreach (@files)
{
   $_ =~ s/.*[\/\\](.*)/$1/;
   push(@cols,td(submit(-name => 'file', -value => $_));
   if (@cols == 4)
   {
      print Tr({-alien => 'center'}, @cols);
      @cols=();
   }
}
if (@cols)
{
   while (@cols < 4)
   {
     push(@cols,td('&nbsp;'));
   }
   print Tr({-alien => 'center'}, @cols);
}

[download]
That builds up a row, and prints it when it's finished. For the last row, it creates cells with a single non-breaking space in them, which avoids formatting annoyances in some browsers.

In reply to Re: foreach problem by sgifford
in thread foreach problem by Nik

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.