In addition to what the others have said, I'd like to point out a huge security hole. I've reformatted the code for clarity, but the following is logically equivalent to what you have:

my $dbh = DBI->connect(
    'DBI:mysql:*********', 
    '*****', 
    '*****', 
    {RaiseError => 1 , AutoCommit => 1}
) || die "Can't Connect: $!";

my $sth = $dbh->prepare(<<END_SQL);
    UPDATE inventory 
    SET img="$short_name", thumb="$short_tname" 
    WHERE partno="$img_name";
ENDSQL
$sth->execute;

[download]

Never allow user to be able to send data directly to the database like this. If you do, you open yourself up to SQL injection attacks where the attacker can insert their own SQL and run it arbitrarily against the server. You can protect against this by using the $dbh->quote method on the variables before you insert them. However, a cleaner strategy is to always use placeholders:

my $sth = $dbh->prepare(<<END_SQL);
    UPDATE inventory 
    SET    img = ?, thumb = ? 
    WHERE  partno = ?;
ENDSQL
$sth->execute($short_name, $short_tname, $img_name);

[download]

Read "Placeholders and Bind Values" in the DBI documentation for more information.

Cheers,
Ovid

New address of my CGI Course.

In reply to Re: Need help with syntax error in CGI script (security hole) by Ovid
in thread Need help with syntax error in CGI script by apariah2

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.