Do yourself a favour and implement a dispatch table. This additional level of indirection may seem a maintenance burden, but it will sure pay off in the long run. You will know exactly when and why it's failing, and you will also minimize the risk of malicious code injection.

Here's a sketch:

#!/usr/bin/perl use strict; use warnings; use Carp; { my %actions = ( one => \&one, two => \&two, three => \&three ); sub dispatch { # detect early all invalid arguments my @invalid = grep {!exists($actions{$_})} @_; if (@invalid) { local $" = ', '; croak("invalid action(s): (@invalid)"); # or the death spell of your choice } # else { for (@_) { # call $actions{$_}->(...), for example: $actions{$_}->("<<$_>>"); } # } } } # stub subs generator for exemplification only BEGIN { eval 'sub ' . $_ . q{ { local $" = ', '; print "sub [@{[(caller 0)[3]]}] with args: (@_)\n"; }} for qw/one two three/; } dispatch(qw/one two three/); dispatch(qw/three two one kaboom silence/);

Don't just cut and paste my code. I don't have the slightest idea about what you're trying to do with your program. The code above is not substitute for your own judgement.

P.S. If you decide to use symbol tables instead of plain hashes for lookup, as other people have suggested in this thread, try to use a separate namespace for this purpose and not main::. "Whitelisting" is important from a security perspective.


In reply to Re: Canon concerning coderef calls? by calin
in thread Canon concerning coderef calls? by jobi

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.