Also note that your error handling is incorrect.

Your code: 

   $sth = $dbh->prepare($statement) or die "Couldn't prepare the query
+: $sth->errstr";
my $rv = $sth->execute($filename,$to,$from,$comments,$uldate,$expdate)
+ or die "Couldn't execute query: $dbh->errstr";

[download]

What will happen when $dbh->prepare fails? then $sth will be undefined, and then you go on to the 'or', which calls $sth->errstr. Do you really think this make sense? :)

It would be better to replace $sth->errstr with $dbh->errstr in your first statement, and in your second $sth->errstr would be better...

Update: also why don't you put $expdate = $uldate + 86400 * $expire (after the $expire !~ m/...?) instead of those three if-statements

In reply to Re: What is wrong with this DB insert, place holder problem? by Animator
in thread What is wrong with this DB insert, place holder problem? by awohld

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.