In this node it was mentioned to me that the following code I wrote:

• my @files = map { "$dir/$_" } grep { !/^\.{1,2}$/ && -f "$dir/$_" } @tmp;

Will needlessly ignore filenames named "..\n". This would be obviously true, since I am matching the end with $ that matches the end of a string before a newline. So to fix this I believe changing the code to:

• my @files = map { "$dir/$_" } grep { !/^\.{1,2}\z/ && -f "$dir/$_" } @tmp;

should fix it by matching at the end of the string.

However, where exactly would this be a bug?? This would only be a bug on systems that support a newline in the filename. On windows, ( only system I have access to at the moment ) this is not an issue. You cannot create a filename with a "\n" within it.

Example

use strict;
use warnings;

my $filename1 = "ap\ndd";
my $filename2 = "..\n";

open (OUT, '>', $filename1) or
    die "Error opening file [$filename] for write: $! -- $^E\n";

print OUT "TEST\n\nTEST\n";

close(OUT) or
    die "Error closing file [$filename]: $!\n";
[download]

Either filename will give an error:

C:\src\re\test.pl
Error opening file [..
] for write: Invalid argument -- The filename, directory name, or volu
+me label syntax is incorrect
[download]

. So at least in windows this would not be a bug, since you would never encounter such a filename.

Are there many systems that support such filenames?? I just can't see this being encountered often..

Am I missing something here??

zzSPECTREz

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.