Please use <c>...</c> around your code.

On which OS will your run your code?

• On the Mac, \r is LF and \n is CR, so don't use \r and \n.
• On the Mac, the line is ended by CR, so checking for CRLF on a line basis won't work
• On Windows, you need to use binmode. CRLF becomes LF when a file is read without binmode.
• On unix, what you have should work.

Fix:

# Works on unix.
# Works on Windows.
# Still doesn't work on Mac.

open(IN, '<', $input_file)
   or die "Couldn't open file $input_file: $!\n";
binmode(IN);
while (<IN>) {
   if (/\x0D\x0A/) { die("DOS files not allowed\n"); }
   $total_lines++;
}
[download]

Update: Here's something that works everywhere:

# Works on unix.
# Works on Windows.
# Works on Mac.

{
   open(my $fh, '<', $input_file)
      or die "Couldn't open file $input_file: $!\n";
   binmode($fh);
   my $buf = '';
   while (read($fh, $buf, 1024, length($buf))) {
      if (/\x0D\x0A/) { die("DOS files not allowed\n"); }
      $buf = substr($buf, -1);
   }
}


{      
   open(my $fh, '<', $input_file)
      or die "Couldn't open file $input_file: $!\n";

   while (<$fh>) {
      $total_lines++;
   }
}
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.