two general comments: use code comments, e.g. || /foo\d+/ #match foo1234 and also look at the /x modifier in perlre for embedding whitespace and comments inside the regex itself.
Also, the parens are unnecessary in (/foo/) and (19\d{2}).
Here's a (untested) crack at it (also restructing into one RE, since there are commonalities):
if( /( # start re & capture (?: # non-capturing OR clause for the following cases: \d{1,2}\-\d{1,2}\s\w+ # "03-25 X" | \d{1,2}\w{2}\s\w+ # "03aa X" | \d{1,2}\s\w+ # "12 X" | \w+\s\d{1,2}, # "X 12," | \w+\s\d{1,2}\-\d{1,2}, # "X 12-20," ) \s19\d{2} # the <spaceChar>19xx marker )/gxi ){ ... }

In reply to Re: My code seems messy... by davidrw
in thread My code seems messy... by PerlGrrl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.