IMO if you are improving the robustness of scripts that have not been "developed" but rather "evolved" then theres a reasonable chance the authors will appreciate it, either becuase they never found the time or inclination to do the cleanup, or because they just arent that good at it. Ive known a number of people without strong development backgrounds who couldnt refactor to save their life, but were extremely appreciative when somebody helped them refactor their code.

On the other hand, sometimes people without strong backgrounds in development will not appreciate the changes. Most likely these people wont understand the criteria that you have used to refactor the scripts and won't see any benefit in the changes and may even see it as a personal slight. People like that will always be a pain to deal with so i wouldnt worry too much about them. Just be friendly and not cocky and it should work out ok.

---
$world=~s/war/peace/g

In reply to Re: Consideration for others code by demerphq
in thread Consideration for others code by tcf03

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.