Taking Jenda's response just a step further, rather than use splice (which still could damage the foreach's ability to loop properly, as per Fletch's comment), use grep.

sub man_cfs {
  my ($cashflow, $valid_ports) = @_;

  @$cashflow = grep {
    # only keep the ones whose portfolio_id is not empty.
    $_->{'portfolio_id'} ne ''
  } @$cashflow;

  # loop through the new @$cashflow to do other stuff.
[download]

There are other ways to check for the portfolio_id's truthiness. If 0 is not a valid value, you could just remove the ne '' bit, and let perl evaluate the string in boolean context. If 0 is a valid value, perhaps the portfolio_id element may not exist. In the interests of being fully strict-compliant, perhaps you want exists $_->{'portfolio_id'} and length $_->{'portfolio_id'} - that it both exists, and has a non-zero length, then keep it.

Hope that helps,

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.