34 open(F,$f) || die "OPEN : $!\n"; 35 binmode(F); 41 FILE:{ 42 if(($fsize - $size)<=0) { 43 my $count=0; 44 print "Creating file $nr\n"; 45 open(C,">$nr") || die "CREATE : $!\n"; 46 while($count != $fsize) { 47 $count+=read(F,$buffer,$BUFFER_SIZE); 48 print C $buffer; 49 } 50 close C; 51 last FILE; 52 } 53 else { 54 my $count=0; 55 print "Creating file $nr\n"; 56 open(C,">$nr") || die "CREATE : $!\n"; 57 while($count != $size) { 58 $count+=read(F,$buffer,$BUFFER_SIZE); 59 print C $buffer; 60 } 61 close C; 62 $fsize-=$size; 63 $nr++; 64 redo FILE; 65 } 66 }

You binmode the input filehandle but you don't binmode the output filehandle?

read may not return exactly $BUFFER_SIZE bytes so this could result in an infinite loop.


In reply to Re: File splitting script by jwkrahn
in thread File splitting script by Alien

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.