Here is some advice

• Use File::Spec->catfile for building the directory locations and pathnames
• Dont use constant open form, see open ( my $fh, $rw, $perm ) format
• I think reading in the whole file is probably better for whatever you want, on a modern system
• Don't grep for a file_path if the call requires it to be there

try something like:

#!/usr/bin/perl -l
use strict;
use File::Find;
use File::Spec;

use constant DIRECTORY => '/tmp/rja/find_test';

my @files;

find( \&findsub, __PACKAGE__->DIRECTORY );

@files = grep is_dos_format($_), @files;

foreach my $file (@files) {
    print "FAILED FILE - $file";
}

sub findsub {
    push @files, $File::Find::name;
}

sub is_dos_format {
    my $abs_path = shift;

    open ( my $fh, '<', $abs_path )
        or die "open $abs_path: $!"
    ;

    if ( grep m/\r\n/s, <$fh> ) {
        return 1;
    }

    return undef;

}
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.