I have profiled a program and found that 95% of it's time is spent in this sub.

First the code, then my questions. 

  sub evalTree {
    my $intree = shift;
    my $param = shift;

    local $_ = $intree->{contents}; # A shortcut for the current node

    return 0 unless defined;

    if (/^sub /) {
      return eval->(
                  evalTree($intree->{left},$param),
                  evalTree($intree->{right},$param)
                 );
    
    } elsif (/^[x]$/) {
      return $param->{$_};
    } else {
      return $_;
    }
  }

[download]

Quesitons:
1: when using default variable $_, I assume doing regex match of the beginning is quite silly but I don't know the equivelant of iterating through elements such as....

instead of 

if (/^sub /) {

[download]

Perhaps something like 

if (left($_(0),3) = "sub ")

[download]

?

Question 2: I guess thats it. I realize this is a recursion monster but.... Eesh I might end up posting the whole code.

Let me know if you guys want the whole code.

Otherwise your tomatoes, rotten cabbage, and half eaten apples are appreciated. GSF

In reply to optimization help by GSF

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.