Simplest speedup should be to move from reading line-by-line and using parse () to use getline (). This will pay off even more when you allow binary and/or embedded newlines. I did a small benchmark on my machine:

/home/merijn> cat test.pl #!/pro/bin/perl use strict; use warnings; use Benchmark qw( cmpthese ); use Text::CSV_XS; use IO::Handle; my $csv = Text::CSV_XS->new; my @f; sub diamond { open my $io, "<", "test.csv" or die "test.csv: $!"; while (<$io>) { $csv->parse ($_); @f = $csv->fields; } } # diamond sub intern { open my $io, "<", "test.csv" or die "test.csv: $!"; while (my $row = $csv->getline ($io)) { @f = @$row; } } # intern cmpthese (-5, { "diamond" => \&diamond, "getline" => \&intern }); /home/merijn> wc -l test.csv 12000 test.csv /home/merijn> perl test.pl Rate diamond getline diamond 6.89/s -- -39% getline 11.3/s 64% -- /home/merijn>

You can use the first field to do your after-matches.


Enjoy, Have FUN! H.Merijn

In reply to Re: need to optimize my sub routine by Tux
in thread need to optimize my sub routine by convenientstore

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.