sub file2sha1 {
    my $file=$_[0];
    return '' if -d $file; #have to find out if to prune when a directory is found that doesn't match the regex
    open my $f,"<$file";
    my $sha1 = Digest::SHA1->new;
    $sha1->addfile(*$f);
    return $sha1->hexdigest;
}
  1. You should open the file in "binary" mode to work correctly.
  2. You should verify that the file opened correctly.
  3. *$f makes no sense because $f is a lexical variable that contains a reference to a filehandle.
  4. You should probably use $sha1->digest instead which is half the size of $sha1->hexdigest.
sub file2sha1 {
    my $file = $_[ 0 ];
    return '' if -d $file; #have to find out if to prune when a direct
+ory is found that doesn't match the regex
    open my $f, '<:raw', $file or do {
        warn "Cannot open '$file' $!";
        return;
        };
    my $sha1 = Digest::SHA1->new;
    $sha1->addfile( $f );
    return $sha1->digest;
}

[download]

In reply to Re: scalable duplicate file remover by jwkrahn
in thread scalable duplicate file remover by spx2

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.