I think code review is a good thing, especially on Perl Monks there is a great potential for good. The problem with peer code review in real life is that to start with there are often enormous personality clashes and then everyone might get on, of course there's a slight disturbance everytime a new person joins; therein lies the rub: there'll be new folk joining and opining constantly . How do you stop people having flame wars on the placing of brackets, or something equally irrelevant?

If this excellent suggestion is to be used and be fruitful, there will need to be some rules on what can be commented upon.. i.e Larry Wall's formatting rules should be applied, other than that I've run out of suggestions, but for what it's worth I really like this idea.

--
Brother Frankus.

In reply to Re: Code review by frankus
in thread Code review by toadi

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.