Hi All, i'm learning Perl some scripts. Now i'm working on a file uploading in Perl-CGI. i have a script which retrives the uploaded image from previouse page and display it on browser. Now everything working fine but image alone not displaying on browser. I have given chmod 755 permision for uploadvalid.cgi and 777 permision for 'upload' directory.


That file is given below,

uploadvalid.cgi (path is.... /var/www/cgi-bi/session/cgi/uploadvalid.cgi)


#!/usr/bin/perl -wT
use strict;
use CGI;
use CGI::Carp qw ( fatalsToBrowser );
use File::Basename;
$CGI::POST_MAX = 1024 * 5000;
my $safe_filename_characters = "a-zA-Z0-9_.-";
my $upload_dir = "/var/www/upload";
my $query = new CGI;
my $filename = $query->param("photo");
if ( !$filename )
{
print $query->header ( );
print "There was a problem uploading your photo (try a smaller file).";
exit;
}
my ( $name, $path, $extension ) = fileparse ( $filename, '\..*' );
$filename = $name . $extension;
$filename =~ tr/ /_/;
$filename =~ s/^$safe_filename_characters//g;
if ( $filename =~ /^($safe_filename_characters+)$/ )
{ $filename = $1;}
else { die "Filename contains invalid characters"; }
my $upload_filehandle = $query->upload("photo");
open ( UPLOADFILE, ">$upload_dir/$filename" ) or die "$!";
binmode UPLOADFILE;
while ( <$upload_filehandle> )
{ print UPLOADFILE;}
close UPLOADFILE;
print $query->header ( );
print << END_HTML; <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> <title>Thanks!</title> <style type="text/css"> img {border: none;} </style> </head> <body>

Thanks for uploading your photo!

Your photo:

<img src="/var/www/upload/$filename" alt="Photo" />

</body> </html>
END_HTML

my output on the browser is,

Thanks for uploading your photo!

Your photo:

Photo

i'm using linux system with Apache/2.0.52 (Red Hat).... is there any environmental error. i'm root user. can any one let me know the correction please. Thanks in advance...

In reply to Proble with image on Perl-CGI by daynite

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.