Besides a single >, the thing that the code does in the SERVICE_APPLICATION_EXECUTION_COMPONENT and WEB_APPLICATION_EXECUTION_COMPONENT are identical (as far as I can see). Ensure that the > is really needed there and consider merging the two blocks.

Having the if($os eq 'unx') inside foreach blocks is not a good idea, since the condition is loop-invariant, which means that the outcome of the check inside the ifs won't change, depending on the values of the iterator (foreach). It should be rewritten as:

if(...) {
    foreach ... (...) {
        ...
    }
}

[download]

And again, the two blocks checking for UNX and WNT are nearly identical. See if you can merge them. Redundant redundant code is redundant redundant is redundant.

In reply to Re: smart solution by mzedeler
in thread smart solution by Sun751

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.