Dear Monks,

I'm trying to clean up some existing code to pass perlcritic.

One of the common 'styles' is to have a separate method to trap signals. For example : 

sub trap_signals {
  $SIG{CHLD} = \&handler;
  :

[download]

Now, perlcritic wants me to make a local copy of $SIG (as per page 81 of Perl Best Practices). However in this case the local copy defeats the purpose.

I can of course do something like : 

sub trap_signals {
  my $sig = \%SIG;
  $sig->{CHLD} = \&handler;
  :

[download]

It passes perlcritic but this seems to me to make the code more obscure and no 'safer'.

Is there a 'preferred' approach for dealing with this situation?

Thanks a lot.

H.

In reply to Doing the right thing by perlcritic by horrendo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.