What's the best approach? My solution feels a bit clunky...
You could omit a couple of temporary variables and initialising $rating wouldn't go amiss:
my $hdata = <call that creates the struct>;
my ($rating, $bwurl) = 0;
foreach my $id ( keys %$hdata ) {
if($hdata->{$id}{Season} == $seasonnum && $hdata->{$id}{Rating} >
+$rating){
$rating = $hdata->{$id}{Rating};
$bwurl = $hdata->{$id}{BannerPath};
}
}
But essentially what you have is about as good as it gets.
You might use List::Util::reduce(), but it is certainly no clearer:
use List::Util qw[ reduce ];
...
my $hdata = <call that creates the struct>;
my( $rating, $bwurl ) = @{ reduce{
if( $hdata->{$b}{Season} == $seasonnum && $hdata->{$b}{Rating} > $
+a->[0] ){
$a->[0] = $hdata->{$b}{Rating};
$a->[1] = $hdata->{$b}{BannerPath}
}
} [ 0, '' ], keys %hdata };
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.