After a first glimpse, I'd change this code:
#do the output if($is_script eq 'yes'){ middle(); bottom(); } else { top(); middle(); bottom(); }
to something like this:
top() unless $is_script eq 'yes'; middle(); bottom();

Update: petdance said the same thing explaining it. I didn't noticed his reply (probably he submitted it while I was preparing this one)

You could also consider taking a look at Template as I'm doing in these days. It seems interesting since it lets you separate the logic from the presentation. But this topic has been already discussed in the monastery (Web Application Frameworks and their Templating Engines with a Comparative Study of Template and HTML::Template).


In reply to Re: I know this code could be better... by larsen
in thread I know this code could be better... by derek3000

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.