Consider your code with some indentation added

#!/usr/bin/perl -w use strict ; use diagnostics; use LWP::Simple ; print "This will get the time from an NIST clock 5 times and then ask you if you want to continue. Use 'y' to continue and any other key to stop:\n\n" ; my $answer ; my $quit = 0 ; until ($quit) { getprint("http://132.163.4.101:13") ; getprint("http://132.163.4.101:13") ; getprint("http://132.163.4.101:13") ; getprint("http://132.163.4.101:13") ; getprint("http://132.163.4.101:13") ; print "Do you want to continue? " ; $answer = <STDIN> ; chomp $answer ; } if ($answer ne 'y') { print "OK\n" ; } else { $quit = 1 ; die "OK!\n\n" ; } print "Good-bye!\n\n" ;

I have indented your code as I normally would. The problem as you can see is that you test the conditional outside the until loop. No test == No exit. You could also simplify a lot to this:

#!/usr/bin/perl -w use strict ; use diagnostics; use LWP::Simple ; print "This will get the time from an NIST clock 5 times and then ask you if you want to continue. Use 'y' to continue and any other key to stop:\n\n" ; my $answer = 'y' ; until ($answer !~ /^y$/i ) { getprint("http://132.163.4.101:13") ; getprint("http://132.163.4.101:13") ; getprint("http://132.163.4.101:13") ; getprint("http://132.163.4.101:13") ; getprint("http://132.163.4.101:13") ; print "Do you want to continue? " ; $answer = <STDIN>; chomp $answer; } print "Good-bye!\n\n" ;

I like this structure a lot more as it is simple and skips extra vars. Less code == Less bugs. By using a regex match we allow a little more flexibility with lower case or capital 'Y' acceptable.

cheers

tachyon

s&&rsenoyhcatreve&&&s&n\w+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print


In reply to Re: Can't quit my until loop by tachyon
in thread Can't quit my until loop by ellem

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.