Hi monks

Recently, I've been writing a excel template program based on Win32::OLE. for reusing and code elegance, I've used a callback like what File::Find does. Below is sketch of framework: 

-----------       ------------           -------------    
|excel     |     |           |           |           |
|template  | <== | callback  |   <====   |database   |       
|          |     |           |           |___________|
|          |     |           |
---------        |___________|   <=====  -------------
                                         |            |
                                         |DCOM server |
                                         |            |
                                         --------------

[download]
below are some part of codes: 
sub cell_walk{
    my $self = shift;
    my ($sheet_name, $x, $y, $callback) = @_;
       
       my $Sheet = $self->{ 'book_handle' }->Worksheets($sheet_name);
    for ( $row = $x->[0] ; $row <= $y->[0] ; $row++ ) {
        for ( my $col = $x->[1] ; $col <= $y->[1] ; $col++ ) {
              $callback->($Sheet->Cells( $row, $col ));
        }
    }

}

sub callback{
     
    return if !defined $_[0]->{Value};
        if ( $_[0]->{Value} =~ /^~~~/ ) {
            my @a =
              split( /__/, substr( $_[0]->{Value}, 3 ) );  #grab usefu
+l string
              if( scalar @a == 3){
            $_[0]->{Value} =
              $hl->get_single_LP( 'ADAS_VAL_RAW', @a );
              }
              if( scalar @a == 4){
            $_[0]->{Value} =
              $hl->accu_LP( 'ADAS_VAL_NORM', @a );
              }
        }


}

[download]
Please note $hl in above code, it is a ref from another big object including DBI and Dcom server handles. at this stage, I new it as a global variable and use it in subroutine directly. it make work done but looks ugly.

So Is there any good way to re-organize code to make my source more pretty? Do I need to pass the ref of the obj to callback in advance? Thanks in advance!!!!

UPDATE: correct codes.



I am trying to improve my English skills, if you see a mistake please feel free to reply or /msg me a correction

In reply to how organize code in callback mode by xiaoyafeng

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.