You indicate:
# similar untainting for all other user input here, then...
and:
print MAIL "Subject: $subject\n\n";
so it's not clear what kind of checks you're doing on the subject. Depending on those checks, this script may be an open mail relay or not. For example, suppose the subject is set to:
$subject = "Nice subject\nBcc: john@doe.com, jane@doe.com... ";
the mail you send becomes in fact:
From: $name To: $sendto Subject: Nice subject Bcc: john@doe.com, jane@doe.com... Message: $message
and you've just become a spammer.

So, make sure you filter newlines from $subject as well!

Liz


In reply to Re: Security of Sendmail and -T error by liz
in thread Security of Sendmail and -T error by bradcathey

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.