Use hashes instead of grep

Yes instead of using grep, why aren't you using hashes to determine whether there is anything new in the file? You can build up a hash of all the terms (machines) in file1 and then check the hash to see whether an entry exists for each line of file2.

This would be much quicker than using grep for what you seem to be doing.

A Monk aims to give answers to those who have none, and to learn from those who know more.

Comment on Use hashes instead of grep

Replies are listed 'Best First'.
Re: Use hashes instead of grep by ColonelPanic (Friar) on Nov 15, 2012 at 10:22 UTC
I agree that, all else being equal, this would be the best design. However, it ultimately depends on what the rest of the code does. When's the last time you used duct tape on a duct? --Larry Wall	[reply]
Re^2: Use hashes instead of grep by space_monk (Chaplain) on Nov 15, 2012 at 10:55 UTC
Not really. Even if the code uses both arrays then there is nothing preventing building a temporary hash through `my %hash = map { $_ => 1 } @first_list;` [download] ..and then discarding the hash after the check for new machines. More likely is that he is only interested in the second list, or just new machines, and they could be in an array just like before. A Monk aims to give answers to those who have none, and to learn from those who know more.	[reply] [d/l]
Re^3: Use hashes instead of grep by ColonelPanic (Friar) on Nov 15, 2012 at 11:15 UTC
Yes, but this method is not clearly superior if arrays are needed for other purposes. The array comparison is simpler, uses less memory, and will be fast unless both files are huge. When's the last time you used duct tape on a duct? --Larry Wall	[reply]
Re^4: Use hashes instead of grep by Anonymous Monk on Nov 15, 2012 at 14:18 UTC
Re^4: Use hashes instead of grep by space_monk (Chaplain) on Nov 15, 2012 at 14:01 UTC