Well yes
Tye, you can't XOR something with it-self and expect anything other then 0. That would be illogical. But it is a good point about the
Fisher-Yates Shuffle, if you are using XOR to swap to locations you must be careful that the locations aren't the same... which is probably why the original algorithm does the test.