Hello
killersquirel11. Looks like you've already been given some full rewrites. I just figured I'd give you some smaller points to think about in the future.
if() vs unless() i.e.
if ($#ARGV != 0) -> unless ($#ARGV == 0)
if (not -e $inputFile) -> unless (-e $inputFile)
Multiple Variable Declaration can be broken down from:
my $headerLine= -1;
my $prtIndex = -1;
my $shpIndex = -1;
my $clrIndex = -1;
my $sizIndex = -1;
to:
my ($headerLine, $prtIndex, $shpIndex, $clrIndex, $sizIndex) = -1
my ($headerLine, $prtIndex, $shpIndex, $clrIndex, $sizIndex) = (-1) x 5;
C style for loops like:
sub checkIndices {
my $count;
for ($count=0; $count<=$#_; $count++){
if($_[$count] < 0){
return (1==0);
}
}
return (1==1);
}
Can be "Perl-ified" like:
sub checkIndices {
for my $item (@_){
return (1==0) if ($item < 0)
}
return (1==1);
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.